You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Markdown linting across MUI now runs through ESLint via the markdown: true flag passed to createBaseConfig from @mui/internal-code-infra/eslint. mui-public's own eslint.config.mjs already passes markdown: true, so the separate markdownlint-cli2 self-lint and the shared @mui/internal-code-infra/markdownlint export are redundant and can be removed.
Removed:
Root .markdownlint-cli2.mjs config, the markdownlint script, and the markdownlint-cli2 devDependency in package.json.
The packages/code-infra/src/markdownlint/ directory and the ./markdownlint entry from packages/code-infra/package.json's exports map.
The markdownlint command/job from .circleci/orbs/code-infra.yml (both its definition and its reference in run-linters).
The markdownlint.config setting from .vscode/settings.json.
The ESLint markdown: true flag stays in place as the replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR: out-of-dateThe pull request has merge conflicts and can't be merged.scope: code-infraInvolves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown linting across MUI now runs through ESLint via the
markdown: trueflag passed tocreateBaseConfigfrom@mui/internal-code-infra/eslint. mui-public's owneslint.config.mjsalready passesmarkdown: true, so the separatemarkdownlint-cli2self-lint and the shared@mui/internal-code-infra/markdownlintexport are redundant and can be removed.Removed:
.markdownlint-cli2.mjsconfig, themarkdownlintscript, and themarkdownlint-cli2devDependency inpackage.json.packages/code-infra/src/markdownlint/directory and the./markdownlintentry frompackages/code-infra/package.json'sexportsmap.markdownlintcommand/job from.circleci/orbs/code-infra.yml(both its definition and its reference inrun-linters).markdownlint.configsetting from.vscode/settings.json.The ESLint
markdown: trueflag stays in place as the replacement.